Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: initial MeshAccessLog implementation #5035

Merged
merged 13 commits into from
Sep 23, 2022
Merged

feat: initial MeshAccessLog implementation #5035

merged 13 commits into from
Sep 23, 2022

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Sep 21, 2022 •
edited by lukidzi
Loading

Does not include JSON formatting.

  • Gateway
  • Direct access listeners
  • New incoming request logging for passthrough listeners?

Checklist prior to review

  • Link to docs PR or issue -- Are we documenting these yet?
  • Link to UI issue or PR -- none
  • Is the issue worked on linked? -- MeshAccessLog implementation #4979
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests -- NOT DONE
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here?

Changelog: feat(policy): Add MeshAccessLog policy

@michaelbeaumont michaelbeaumont force-pushed the feat/log_impl branch 2 times, most recently from 9e96288 to af3b668 Compare September 21, 2022 17:15
@michaelbeaumont
feat: MeshAccessLog implementation
e8b1d01 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
fix: properly check http vs tcp
18784fb 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
test(meshaccesslog): add TCP test
591cbb4 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
test(e2e): add MeshAccessLog
4972809 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont marked this pull request as ready for review September 22, 2022 12:42
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner September 22, 2022 12:42
lahabana
lahabana approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nits

pkg/plugins/policies/meshaccesslog/plugin/v1alpha1/access_log_v2.go Outdated Show resolved Hide resolved
pkg/plugins/policies/meshaccesslog/plugin/v1alpha1/plugin.go Outdated Show resolved Hide resolved
@michaelbeaumont
feat: add logging to passthrough listeners
aea1792 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
refactor: extract inbound configuration
b6c528b 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
refactor: move Configurer to xds package
aaa1301 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
feat: apply logging to direct access listeners
17ab7e5 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
fix: early return
f5d88a4 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
test(e2e): increase delay checking logs
cba06d0 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont mentioned this pull request Sep 23, 2022
Closed
1 task
@michaelbeaumont
refactor: move public functions to the top
2e15037 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
Merge remote-tracking branch 'origin/master' into feat/log_impl
eaffa80 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont changed the title feat: MeshAccessLog implementation feat: initial MeshAccessLog implementation Sep 23, 2022
@michaelbeaumont
test(e2e): add passthrough MeshAccessLog test
3280e52 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont enabled auto-merge (squash) September 23, 2022 10:57
@michaelbeaumont michaelbeaumont merged commit d4b3842 into kumahq:master Sep 23, 2022
@michaelbeaumont michaelbeaumont deleted the feat/log_impl branch September 23, 2022 13:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lobkovilya lobkovilya lobkovilya approved these changes

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

@lahabana lahabana lahabana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michaelbeaumont @lahabana @jakubdyszkiewicz @lobkovilya