Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(node-shell): optional pod running timeout #57

Merged
merged 2 commits into from
Dec 26, 2023
Merged

feat(node-shell): optional pod running timeout #57

merged 2 commits into from
Dec 26, 2023

Conversation

maxime1907
Copy link
Contributor

@maxime1907 maxime1907 commented Sep 15, 2023 •
edited
Loading

Solves #53

Tested with:

KUBECTL_NODE_SHELL_POD_RUNNING_TIMEOUT="2m" sh -x kubectl-node_shell kind-control-plane -- ls -all
sh -x kubectl-node_shell kind-control-plane -- ls -all

@maxime1907
Copy link
Contributor Author

cc @kvaps

@maxime1907
Copy link
Contributor Author

cc @kvaps could you merge this and release please ?

kvaps
kvaps reviewed Nov 8, 2023
View reviewed changes
@maxime1907
feat(node-shell): optional pod running timeout
d25b680 
Signed-off-by: Maxime Leroy <19607336+maxime1907@users.noreply.github.com>
@maxime1907 maxime1907 force-pushed the supportrunningtimeout branch from b66d689 to d25b680 Compare November 8, 2023 11:30
@kvaps kvaps merged commit 8e91eb1 into kvaps:master Dec 26, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kvaps kvaps kvaps left review comments

@klinda01 klinda01 klinda01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxime1907 @kvaps @klinda01