Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

A minor speed improvement? #5

Merged
merged 1 commit into from
Oct 25, 2011
Merged

A minor speed improvement? #5

merged 1 commit into from
Oct 25, 2011
+1 −1

Conversation

elidupuis
Copy link
Contributor

String.match returns unnecessary array info while Regex.test returns only a true or false, which is all we need.

Theoretically, this will be faster. Barely :)

kylefox added a commit that referenced this pull request Oct 25, 2011
@kylefox
Merge pull request #5 from elidupuis/master
31c14a2 
A minor speed improvement?
@kylefox kylefox merged commit 31c14a2 into kylefox:master Oct 25, 2011
@kylefox
Copy link
Owner

kylefox commented Oct 25, 2011

Thanks -- nice catch!

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elidupuis @kylefox