Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix blocker z-index issue #84

Merged
merged 1 commit into from
Dec 4, 2014

Conversation

okuyan
Copy link

@okuyan okuyan commented Aug 6, 2014

To avoid modal going behind the blocker. related to #70
Same fix as https://github.com/dei79/jquery-modal-rails/pull/14/files in any element type of designated modal content.

To avoid modal going behind the blocker kylefox#70
@kylefox
Copy link
Owner

kylefox commented Aug 7, 2014

I think I understand what this does.

Instead of having to do $(html).appendTo('body').modal(); you can simply do $(html).modal(); — is that the intention of this patch?

Thanks!

@okuyan
Copy link
Author

okuyan commented Aug 8, 2014

I had a similar z-index issue to #70 which modal content goes behind the overlay. It only happens in Android default browser, but not in regular browsers. So, I can't provide the code how the issue happens. I thought the patch d11b6790b0c4e2cd50364bc22b3304f4493355bc is good to make sure the main contents css will never affect to modal content itself. So I wanted to do the same thing when el is not "a". This resolved my issue.

Thanks!

@okuyan okuyan closed this Aug 8, 2014
@okuyan okuyan reopened this Aug 8, 2014
@sjamaan
Copy link
Contributor

sjamaan commented Dec 2, 2014

Please consider merging this; I had the same problem with the whole page including the modal itself being grayed out, and okuyan's branch fixed it.

kylefox added a commit that referenced this pull request Dec 4, 2014
@kylefox kylefox merged commit 125da70 into kylefox:master Dec 4, 2014
@kylefox
Copy link
Owner

kylefox commented Dec 4, 2014

Done, thanks for the fix.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants