Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove provisioning skip option in skr tests #286

Merged
merged 5 commits into from
Dec 22, 2023
Merged

Remove provisioning skip option in skr tests #286

merged 5 commits into from
Dec 22, 2023

Conversation

MarekMichali
Copy link
Contributor

@MarekMichali MarekMichali commented Dec 19, 2023 •
edited
Loading

Description

Skip provisioning was used for own cluster plan and is no longer needed.

Changes proposed in this pull request:

Related issue(s)

See #153

@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. labels Dec 19, 2023
@github-actions GitHub Actions
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 19, 2023
@MarekMichali MarekMichali marked this pull request as ready for review December 22, 2023 06:46
@MarekMichali MarekMichali requested a review from a team as a code owner December 22, 2023 06:46
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 22, 2023
@MarekMichali
Copy link
Contributor Author

/kind enhancement

@kyma-bot kyma-bot added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Dec 22, 2023
@MarekMichali
Copy link
Contributor Author

/test pre-kyma-environment-broker

szwedm
szwedm approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@szwedm szwedm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 22, 2023
@MarekMichali
Copy link
Contributor Author

/test pre-kyma-environment-broker

1 similar comment
@MarekMichali
Copy link
Contributor Author

/test pre-kyma-environment-broker

@kyma-bot kyma-bot merged commit e900e8c into kyma-project:main Dec 22, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@szwedm szwedm szwedm approved these changes

Assignees

@szwedm szwedm

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarekMichali @kyma-bot @szwedm