Added option to right click in chests #24
Conversation
|
Have you verified that this does not lead to any instances of dupes? I always avoided implementing this at risk of the changes contents of the shulker not being saved properly with the chest. Can you run some tests, on a server as well? Changing the contents of the shulker, make the chunk save and load and see if it persists |
|
Only tested briefly in singleplayer, I figured there was a reason you limited that functionality haha. I'll get back to you once I've ran some tests. |
|
I think it's also important to know what happens when the opened shulker gets moved. What if another player opens the chest and takes out the shulker you have opened? Or if a hopper takes it? Or another player breaks the chest? Thank you for testing this, if we can get it working properly without the potential for dupes, i'm not opposed to merging it |
|
RIP, dupes do happen if a player takes the shulker box out of the chest while it's in use. |
|
That's unfortunate. If you can figure out a way to prevent this, feel free to. Perhaps auto closing the opened shulker when it's detected that it's moved, in an effective way. This fix could be beneficial for normal use as well. It would have to be server side of course. Maybe an event that could get fired when the item was moved? Or tick the opened handled screen and verify if the item is still in its location? |
|
I think a limited version of this works when used only for ender-chests. If I understand correctly the dupe process, player A opens the shulker from within the chest, player B concurrently removes the shulker from the chest, player A closes the shulker and repopulates the chest slot with the (now duplicate) shulker. When the player is accessing the opened shulker from within the ender-chest, he cannot access the source ender-chest anymore in the interface, and other players cannot assist in duping by accessing the chest concurrently, so there should be no dupe (?) |
No description provided.