Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix Duping by disabling shulker opening in Hotbar / Offhand #48

Open
wants to merge 2 commits into
base: 1.18
Choose a base branch
from

Conversation

aria1th
Copy link

@aria1th aria1th commented Feb 25, 2022

Proper fix should be mixin into InteractionManager, and prevent further useBlock action while it was processing Screen exchange.

Proper fix should be mixin into InteractionManager, and prevent further useBlock action while it was processing Screen exchange.
@kyrptonaught
Copy link
Owner

This disables the shulker from being opened from the hotbar or offhand? That's kind of removing a core feature IMO. I think the duping was mostly mitigated to just creative only. There are checks now to make sure the item still exists where it was supposed to be before allowing you use the opened shulker, this removed the dupe from survivial now.

I do agree about the proper fix, just unsure about how to do it. The fix needs to be server sided, else the client could just not update or modify the jar. The server would have to ignore the clients place block/interact block packets while the opened shulker is being opened.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants