Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

LXDE (Pcmanfm) support (WIP) #80

Merged
merged 11 commits into from
Oct 27, 2016
Merged

LXDE (Pcmanfm) support (WIP) #80

merged 11 commits into from
Oct 27, 2016

Conversation

daf
Copy link
Member

@daf daf commented Oct 23, 2016

Fixes #63

Adding setter backend for Pcmanfm (aka what LXDE uses).

TODO:

  • Clean up exception pathways
  • Make sure Currently Set strings in UI make sense
  • Don't prompt for saving/dirty flag
  • Make sure configs don't crash pcmanfm!

Since Pcmanfm's command line switch can't take a monitor parameter in any way, it always defaults to monitor 0, which means Nitrogen can't control the other heads as appropriate. Therefore, we directly manipulate the Pcmanfm desktop configuration files and send it a SIGUSR1 which seems to reload it. I'm not sure this is an incredibly stable approach, though.

@daf daf added this to the 1.6 milestone Oct 27, 2016
@daf daf self-assigned this Oct 27, 2016
@daf
Copy link
Member Author

daf commented Oct 27, 2016

There's just not a lot I can do about stability with the SIGUSR1 approach, I can't tell even what does the restart in an LXDE session. We're going to call this a "beta" feature :)

@daf daf merged commit 665fca2 into master Oct 27, 2016
@daf daf deleted the lxde branch October 27, 2016 01:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant