Proposal: Allow to adjust token validity for Api Clients via Terraform #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demeyerthom
requested changes
Nov 26, 2024
There was a problem hiding this comment.
Hi @mlitvinav this looks good! Would you mind fully implementing the logic? I think it is just a case of passing the two additional fields to the draft if they are present.
Also, the changes file you added is incorrect. These are generated automatically from the contents of the .changes/unreleased folder. You can generate a new one with changie new (see https://changie.dev/guide/installation/)
mlitvinav
force-pushed
the
allow-to-adjust-token-validity-for-api-clients
branch
from
d041567 to
ecc1f64
Compare
|
Hi @demeyerthom, i have created the change via |
demeyerthom
approved these changes
Dec 3, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API Clients allow to override the default token validity but this is only possible during the creation of the api client.
While the access_token's are valid for 48 hours, the lifetime of refresh_tokens is 200 days, which is pretty high. I would like to be able to set custom validity values for the api clients. Especially because there is no way to update existing clients, so after creation hooks wont work here.
NEW FEATURES | UPGRADE NOTES | ENHANCEMENTS | BUG FIXES | EXPERIMENTS
Extends
resource_api_clientto read and write the fieldsaccessTokenValiditySecondsandrefreshTokenValiditySeconds.Please double check if these changes are good to go. It seems there is not much that needs to be changed but i am unfamiliar with Go and working with TF providers.