Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: added check that no enum types are deleted #571

Merged
merged 1 commit into from
Feb 28, 2025
Merged

fix: added check that no enum types are deleted #571

merged 1 commit into from
Feb 28, 2025

Conversation

demeyerthom
Copy link
Member

@demeyerthom demeyerthom commented Feb 21, 2025 •
edited
Loading

Fixes #569

NEW FEATURES | UPGRADE NOTES | ENHANCEMENTS | BUG FIXES | EXPERIMENTS

  • Throw error when deleting an enum type. This still allows for renaming enum types, it only checks if the total number of new values is smaller than old values

@demeyerthom demeyerthom requested a review from a team as a code owner February 21, 2025 15:09
@demeyerthom demeyerthom linked an issue Feb 21, 2025 that may be closed by this pull request
address enum fails to update #569
Closed
@demeyerthom demeyerthom force-pushed the 569-address-enum-fails-to-update branch from a61e853 to cf08940 Compare February 28, 2025 09:51
@demeyerthom demeyerthom requested a review from webwiebe February 28, 2025 09:59
@demeyerthom demeyerthom merged commit 374cd53 into main Feb 28, 2025
2 checks passed
@demeyerthom demeyerthom deleted the 569-address-enum-fails-to-update branch February 28, 2025 12:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@webwiebe webwiebe webwiebe approved these changes

@MichielBijland MichielBijland Awaiting requested review from MichielBijland MichielBijland is a code owner automatically assigned from labd/go

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

address enum fails to update
2 participants
@demeyerthom @webwiebe