This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
fix: Improve shutdown with live sessions #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* We should use "shutdown" signal handlers to interrupt ongoing connections with aiohttp, instead of the "cleanup" context. * Unify `stream_key` in the gateay.stream module to use the kernel ID. We are no longer codeonweb.com.... * Fix a rare bogus error at the ratelimiter upon shutdown.
Codecov Report
@@ Coverage Diff @@
## master #365 +/- ##
=======================================
Coverage 49.26% 49.26%
=======================================
Files 51 51
Lines 7589 7591 +2
=======================================
+ Hits 3739 3740 +1
- Misses 3850 3851 +1
Continue to review full report at Codecov.
|
achimnol
added a commit
that referenced
this pull request
Dec 17, 2020
* We should use "shutdown" signal handlers to interrupt ongoing connections with aiohttp, instead of the "cleanup" context. * Unify `stream_key` in the gateay.stream module to use the kernel ID. We are no longer codeonweb.com.... * Fix a rare bogus error at the ratelimiter upon shutdown. Backported-From: master Backported-To: 20.03
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.