This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
fix: Replace aioredlock with pg_advisory_lock #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #482 +/- ##
==========================================
+ Coverage 48.67% 48.77% +0.09%
==========================================
Files 54 54
Lines 8879 8882 +3
==========================================
+ Hits 4322 4332 +10
+ Misses 4557 4550 -7
Continue to review full report at Codecov.
|
fix: Update comment in dispatcher mentioning aioredlock
achimnol
changed the title
achimnol
added a commit
that referenced
this pull request
Oct 4, 2021
* setup: Remove aioredlock from our requirements * test: Silence etcd3 deprecation warnings Backported-From: main (21.09) Backported-To: 21.03
achimnol
added a commit
that referenced
this pull request
Oct 5, 2021
* Use pg_try_advisory_lock() combined with client-side sleep
- This will avoid being affected by arbitrary statement and lock timeout configs
as well as TCP keepalive configs, with a small sacrifice on CPU cycles
and network traffic at the database connection for each timer.
* refactor: Single-source the database creation routine
as models.utils.connect_database()
achimnol
added a commit
that referenced
this pull request
Oct 5, 2021
* Use pg_try_advisory_lock() combined with client-side sleep
- This will avoid being affected by arbitrary statement and lock timeout configs
as well as TCP keepalive configs, with a small sacrifice on CPU cycles
and network traffic at the database connection for each timer.
* refactor: Single-source the database creation routine
as models.utils.connect_database()
Backported-From: main (21.09)
Backported-To: 21.03
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.