fix: activate superadmin's all vfolder listing feature #1237
+92
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizable
requested changes
Feb 22, 2022
| @@ -363,11 +363,11 @@ export default class BackendAiResourceBroker extends BackendAIPage { | |||
| * Update virtual folder list. Also divide automount folders from general ones. | |||
| * | |||
| */ | |||
| async updateVirtualFolderList() { | |||
| async updateVirtualFolderList(userEmail = false) { | |||
There was a problem hiding this comment.
The type of default value of parameter userEmail doesn't seem to have a match with SDK function in here.
It's string, not boolean.
| const ownerEnabled = this.shadowRoot.querySelector('#owner-enabled'); | ||
| const userEmail = this.shadowRoot.querySelector('#owner-email').value; | ||
| if (ownerEnabled && ownerEnabled.checked) { | ||
| await this.resourceBroker.updateVirtualFolderList(userEmail).then(() => { |
There was a problem hiding this comment.
Any reason for using await keyword and .then() keyword at the same time?
src/lib/backend.ai-client-node.ts
Outdated
| let reqUrl = this.urlPrefix; | ||
| if (groupId) { | ||
| const params = {group_id: groupId}; | ||
| if (groupId || userEmail) { |
There was a problem hiding this comment.
I think it's better to use condition statements separately.
|
I just updated two things during delegate session creation:
|
|
@lizable Great! |
inureyes
approved these changes
Apr 12, 2022
inureyes
added
effort:easy
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve: lablup/backend.ai#321
related: lablup/backend.ai-manager#544
When I tested, the function is working.
Trying with the admin accesskey, I get an error. Trying with the folder owner accesskey it succeeds.
But in webui, superadmin can't know all vfolders. This is because superadmin's all folder view function did not work.
It was already implemented in the backend. One parameter required by the backend was missing, so add it.
It works well. (The two folders in the picture below are folders created by different accounts as shown in the picture above.)
To reduce the load, it request only one-time when superadmin check delegated session start checkbox.
