Feature: Session lifetime config in resource policy #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizable
added
type:enhance
adrysn
requested changes
May 9, 2022
Comment on lines
3373
to
3375
| @click="${(e) => {this._chooseResourceTemplate(e);}}" | ||
| @click="${(e) => { | ||
| this._chooseResourceTemplate(e); | ||
| }}" |
There was a problem hiding this comment.
hmm, I guess it's because of "eslint" code styling. I'll revert to the previous code style.
There was a problem hiding this comment.
Perhaps, we need to update the eslint config not to rearrange the code in a weird way.
adrysn
requested changes
May 9, 2022
Comment on lines
3444
to
3446
| @change="${(e) => {this._applyResourceValueChanges(e); this._updateShmemLimit()}}" | ||
| @change="${(e) => { | ||
| this._applyResourceValueChanges(e); this._updateShmemLimit(); | ||
| }}" |
Comment on lines
3459
to
3463
| @change="${(e) => {this._applyResourceValueChanges(e); this._updateShmemLimit()}}" | ||
| @change="${(e) => { | ||
| this._applyResourceValueChanges(e); this._updateShmemLimit(); | ||
| }}" |
I couldn't agree more about updating our linting rules. I found a workaround plugin that doesn't ruin the indentation of template literal (not 100% but, much better than the current linting rules). I'll apply it as a new feature and make PR for it. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves a new configuration
max_session_lifetime, which can be applied in resource policy.Related: manager#583
Before
After