Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Feature: num retries config in resource group #1305

Merged
merged 4 commits into from
May 10, 2022
Merged

Feature: num retries config in resource group #1305

merged 4 commits into from
May 10, 2022

Conversation

lizable
Copy link
Contributor

@lizable lizable commented May 9, 2022

Description

This PR resolves configuringnum_retries_to_skip value in resource group(scaling_groups in backend.ai-manager) in webUI.
Related: manager#527

⚠️ NOTE:

  • If the value is empty, then It fallbacks to num_retries_to_skip value in default setting in etcd (manager).
  • If the intial value in default setting is "3" (ref: sample.etcd.config.json).
  • This feature is available from 22.03.

Before

  • Create Resource Group Dialog

Create-Resource-Group-before

  • Modify Resource Group Dialog

Modify-Resource-Group-before

  • Resource Group Detail Dialog

Resource-Group-detail-before

After

  • Create Resource Group Dialog

Create-Resource-Group

  • Modify Resource Group Dialog

Modify-Resource-Group

  • Resource Group Detail Dialog

Resource-Group-detail

@lizable lizable added type:enhance Add new features good first issue effort:easy Need to understand only a specific region of codes (good first issue, easy). area:ux UI / UX issue. labels May 9, 2022
@lizable lizable added this to the 22.03 milestone May 9, 2022
@lizable lizable requested review from inureyes, adrysn and agatha197 May 9, 2022 11:01
@lizable lizable self-assigned this May 9, 2022
@github-actions github-actions bot added the area:i18n Localization label May 9, 2022
adrysn
adrysn requested changes May 9, 2022
View reviewed changes
Copy link
Member

@adrysn adrysn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor description text issue.

@lizable lizable requested a review from adrysn May 9, 2022 15:21
adrysn
adrysn requested changes May 9, 2022
View reviewed changes
src/components/backend-ai-resource-group-list.ts Outdated
if (value['num_retries_to_skip']) {
return html`
<vaadin-item>
<div><strong># retries to skip</strong></div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more location that needs a little more detail.

@lizable lizable requested a review from adrysn May 9, 2022 17:19
adrysn
adrysn approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@adrysn adrysn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@adrysn adrysn merged commit a6759b8 into main May 10, 2022
@adrysn adrysn deleted the feature/num-retries-config-in-resource-group branch May 10, 2022 00:58
@inureyes inureyes removed the effort:1 label Mar 27, 2023
@Yaminyam Yaminyam added the size:M 30~100 LoC label Apr 13, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@adrysn adrysn adrysn approved these changes

@inureyes inureyes Awaiting requested review from inureyes

@agatha197 agatha197 Awaiting requested review from agatha197

Assignees

@lizable lizable

Labels
area:i18n Localization area:ux UI / UX issue. effort:easy Need to understand only a specific region of codes (good first issue, easy). size:M 30~100 LoC type:enhance Add new features
Projects
None yet
Milestone
22.03
Development

Successfully merging this pull request may close these issues.
4 participants
@lizable @adrysn @inureyes @Yaminyam