Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: send cookie to coordinator for auth to release app ports #958

Merged
merged 3 commits into from
Apr 29, 2021

Conversation

adrysn
Copy link
Member

@adrysn adrysn commented Apr 24, 2021

This PR is needed to release app ports by proxy-coordinator.

Related; https://github.com/lablup/backend.ai-proxy-coordinator/pull/7

@adrysn adrysn self-assigned this Apr 24, 2021
@adrysn adrysn requested review from inureyes and lizable April 24, 2021 15:10
@adrysn adrysn added the type:enhance Add new features label Apr 24, 2021
@adrysn adrysn added this to the 21.03 milestone Apr 24, 2021
inureyes added a commit that referenced this pull request Apr 27, 2021
inureyes added a commit that referenced this pull request Apr 27, 2021
* feat: add edu-applauncher component and page (WIP)

When user accesses /edu-applauncher URL, it will automatically create a
session and launch jupyter notebook. If there is already a session, only
launch jupyter.

* feat: add session template list SDK

* feat: accept app name to launch as a query param

More concrete launch of the app in resuing case.

* feat: create a new session with session template

* fix: eslint (#958)

Co-authored-by: Jeongkyu Shin <inureyes@gmail.com>
@adrysn adrysn added the urgency label Apr 27, 2021
Copy link
Member

@inureyes inureyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inureyes inureyes merged commit 3caa956 into main Apr 29, 2021
@inureyes inureyes deleted the feat/send-cookie-to-coordinator-to-release-app-port branch April 29, 2021 15:36
@Yaminyam Yaminyam added the size:S 10~30 LoC label Apr 13, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
size:S 10~30 LoC type:enhance Add new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants