Rework timeout middleware to use http.TimeoutHandler implementation. … #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1801 +/- ##
=======================================
Coverage 89.56% 89.57%
=======================================
Files 32 32
Lines 2646 2648 +2
=======================================
+ Hits 2370 2372 +2
Misses 178 178
Partials 98 98
Continue to review full report at Codecov.
|
aldas
force-pushed
the
fix_1761_timeout_middleware_datarace
branch
from
6706199 to
0afd577
Compare
aldas
force-pushed
the
fix_1761_timeout_middleware_datarace
branch
from
0afd577 to
736820f
Compare
|
This is quite some interesting code to review @aldas ;-) As we just introduced the timeout Middleware with v4.2.0 I think a breaking change is acceptable due to a functional issue (datarace). So I'm in favor of merging this for v4.2.1 |
lammel
approved these changes
Mar 8, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1761 - Reworked timeout middleware to use
http.TimeoutHandlerimplementation.NB: Replaced
ErrorHandlerwithErrorMessageandOnTimeoutRouteErrorHandleron config struct (fix #1761) - this is breaking change but forhttp.TimeoutHandlerthere is no special case for timeout errors - that handler will take care of it itself.