Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: route containing escaped colon is not actually matched to the request path #2047

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

aldas
Copy link
Contributor

@aldas aldas commented Dec 16, 2021

Route containing escaped colon should be matchable to request path with colon but is not actually matched (fixes #2046)

@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #2047 (ffef4c0) into master (7bde9ae) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2047   +/-   ##
=======================================
  Coverage   91.33%   91.33%           
=======================================
  Files          33       33           
  Lines        2872     2875    +3     
=======================================
+ Hits         2623     2626    +3     
  Misses        159      159           
  Partials       90       90           
Impacted Files Coverage Δ
router.go 95.76% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bde9ae...ffef4c0. Read the comment docs.

@aldas aldas requested a review from lammel December 16, 2021 21:09
Copy link
Contributor

@lammel lammel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, good catch ;-)

@aldas aldas merged commit 6b5e62b into labstack:master Dec 17, 2021
@aldas aldas deleted the fix_2046_colon_escaping branch July 12, 2022 19:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Escaping colon does not work
2 participants