Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Proper colon support in reverse #2416

Merged
merged 4 commits into from
Apr 16, 2023

Conversation

mihard
Copy link
Contributor

@mihard mihard commented Mar 12, 2023

A small follow-up for #1988 - add support of \\: into Reverse method of the router

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (de1c798) 92.87% compared to head (b31bae7) 92.88%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2416   +/-   ##
=======================================
  Coverage   92.87%   92.88%           
=======================================
  Files          39       39           
  Lines        4521     4526    +5     
=======================================
+ Hits         4199     4204    +5     
  Misses        234      234           
  Partials       88       88           
Impacted Files Coverage Δ
router.go 97.81% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mihard
Copy link
Contributor Author

mihard commented Apr 6, 2023

Hi @aldas ,
Could you please review my PR?

@mihard
Copy link
Contributor Author

mihard commented Apr 16, 2023

@aldas pls check again

Copy link
Contributor

@aldas aldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aldas aldas merged commit 7d54690 into labstack:master Apr 16, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants