Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Error when adding VentilationFan with VentilationControl object #1012

Closed
marctavenier opened this issue May 29, 2024 · 2 comments · Fixed by ladybug-tools/honeybee-openstudio-gem#338
Closed

Error when adding VentilationFan with VentilationControl object #1012

marctavenier opened this issue May 29, 2024 · 2 comments · Fixed by ladybug-tools/honeybee-openstudio-gem#338
Assignees
@chriswmackey
Labels
bug Something isn't working

Comments

@marctavenier
Copy link

When adding a VentilationFan with a VentilationControl object that includes an On-Off schedule, OpenStudio throws an error. The error message is as follows:

SWIG director method error. NoMethodError: undefined method `setOpeningAreaFractionSchedule' for #OpenStudio::Model::ZoneVentilationDesignFlowRate:0x0000021c9585b1b0

Traceback (most recent call last):
C:/Program Files/ladybug_tools/resources/measures/honeybee_openstudio_gem/lib/to_openstudio/ventcool/fan.rb:108:in to_openstudio' C:/Program Files/ladybug_tools/resources/measures/honeybee_openstudio_gem/lib/to_openstudio/geometry/room.rb:442:in block in to_openstudio'
C:/Program Files/ladybug_tools/resources/measures/honeybee_openstudio_gem/lib/to_openstudio/geometry/room.rb:440:in each' C:/Program Files/ladybug_tools/resources/measures/honeybee_openstudio_gem/lib/to_openstudio/geometry/room.rb:440:in to_openstudio'
C:/Program Files/ladybug_tools/resources/measures/honeybee_openstudio_gem/lib/to_openstudio/model.rb:473:in block in create_rooms' C:/Program Files/ladybug_tools/resources/measures/honeybee_openstudio_gem/lib/to_openstudio/model.rb:471:in each'
C:/Program Files/ladybug_tools/resources/measures/honeybee_openstudio_gem/lib/to_openstudio/model.rb:471:in create_rooms' C:/Program Files/ladybug_tools/resources/measures/honeybee_openstudio_gem/lib/to_openstudio/model.rb:189:in create_openstudio_objects'
C:/Program Files/ladybug_tools/resources/measures/honeybee_openstudio_gem/lib/to_openstudio/model.rb:93:in to_openstudio_model' C:/Program Files/ladybug_tools/resources/measures/honeybee_openstudio_gem/lib/measures/from_honeybee_model/measure.rb:116:in run'

If I understand correctly the assigned schedule affects the OpeningAreaFraction, but a VentilationFan does not have an OpeningAreaFraction.
@chriswmackey
Copy link
Member

Thanks for finding and reporting this bug, @marctavenier . I am able to recreate it and I will push a fix shortly.

@chriswmackey chriswmackey added the bug Something isn't working label Jun 3, 2024
@chriswmackey chriswmackey self-assigned this Jun 3, 2024
@chriswmackey
Copy link
Member

I have the fix ready and I verified that it's working correctly:

image

@chriswmackey chriswmackey mentioned this issue Jun 3, 2024
Merged
chriswmackey added a commit to ladybug-tools/honeybee-openstudio-gem that referenced this issue Jun 3, 2024
@chriswmackey
fix(fan): Fix typo in fan ventilation schedule
c6b5abb 
Resolves ladybug-tools/honeybee-energy#1012
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@chriswmackey chriswmackey

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(fan): Fix typo in fan ventilation schedule chriswmackey/honeybee-openstudio-gem
2 participants
@chriswmackey @marctavenier