feat(hvac): Refactor HVAC to be extensible for future systems #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriswmackey
added
enhancement
This was referenced Jan 13, 2020
chriswmackey
added a commit
to chriswmackey/honeybee-energy-standards
that referenced
this pull request
Jan 13, 2020
This commit brings the tests in line with [this PR](ladybug-tools/honeybee-energy#69) on honeybee_energy.
chriswmackey
added a commit
to chriswmackey/honeybee-schema
that referenced
this pull request
Jan 13, 2020
This commit overhauls how HVAC systems are represented in the schema. Specifically, it makes it possible in the future to support HVAC systems that are assigned to multiple Rooms (like most of the HVAC system templates in honeybee_legacy). It also restructures the representation of HVAC within the Model schema in order to support this. This commit is coordinated with [this PR over on honeybee_energy](ladybug-tools/honeybee-energy#69)
chriswmackey
added a commit
to chriswmackey/honeybee-grasshopper-core
that referenced
this pull request
Jan 13, 2020
This commit brings the plugin up-to-date with [this recent one on honeybee_energy](ladybug-tools/honeybee-energy#69).
chriswmackey
force-pushed
the
master
branch
2 times, most recently
from
ad1afb6 to
2784497
Compare
chriswmackey
added a commit
to chriswmackey/honeybee-schema
that referenced
this pull request
Jan 14, 2020
This commit overhauls how HVAC systems are represented in the schema. Specifically, it makes it possible in the future to support HVAC systems that are assigned to multiple Rooms (like most of the HVAC system templates in honeybee_legacy). It also restructures the representation of HVAC within the Model schema in order to support this. This commit is coordinated with [this PR over on honeybee_energy](ladybug-tools/honeybee-energy#69)
chriswmackey
added a commit
to chriswmackey/honeybee-openstudio-gem
that referenced
this pull request
Jan 14, 2020
This commit overhauls how HVAC systems are represented in the schema. Specifically, it makes it possible in the future to support HVAC systems that are assigned to multiple Rooms (like most of the HVAC system templates in honeybee_legacy). It also restructures the representation of HVAC within the Model schema in order to support this. This commit is coordinated with [this PR over on honeybee_energy](ladybug-tools/honeybee-energy#69) and [this PR in honeybee_shcema](ladybug-tools/honeybee-schema#12)
chriswmackey
added a commit
to chriswmackey/honeybee-grasshopper-energy
that referenced
this pull request
Jan 14, 2020
This commit brings the plugin up-to-date with [this recent one on honeybee_energy](ladybug-tools/honeybee-energy#69).
chriswmackey
added a commit
to chriswmackey/honeybee-grasshopper-energy
that referenced
this pull request
Jan 14, 2020
This commit brings the plugin up-to-date with [this recent one on honeybee_energy](ladybug-tools/honeybee-energy#69).
chriswmackey
added a commit
to chriswmackey/honeybee-openstudio-gem
that referenced
this pull request
Jan 14, 2020
This commit overhauls how HVAC systems are represented in the schema. Specifically, it makes it possible in the future to support HVAC systems that are assigned to multiple Rooms (like most of the HVAC system templates in honeybee_legacy). It also restructures the representation of HVAC within the Model schema in order to support this. This commit is coordinated with [this PR over on honeybee_energy](ladybug-tools/honeybee-energy#69) and [this PR in honeybee_shcema](ladybug-tools/honeybee-schema#12)
chriswmackey
added a commit
to chriswmackey/honeybee-schema
that referenced
this pull request
Jan 14, 2020
This commit overhauls how HVAC systems are represented in the schema. Specifically, it makes it possible in the future to support HVAC systems that are assigned to multiple Rooms (like most of the HVAC system templates in honeybee_legacy). It also restructures the representation of HVAC within the Model schema in order to support this. This commit is coordinated with [this PR over on honeybee_energy](ladybug-tools/honeybee-energy#69)
chriswmackey
added a commit
to chriswmackey/honeybee-openstudio-gem
that referenced
this pull request
Jan 14, 2020
This commit overhauls how HVAC systems are represented in the schema. Specifically, it makes it possible in the future to support HVAC systems that are assigned to multiple Rooms (like most of the HVAC system templates in honeybee_legacy). It also restructures the representation of HVAC within the Model schema in order to support this. This commit is coordinated with [this PR over on honeybee_energy](ladybug-tools/honeybee-energy#69) and [this PR in honeybee_shcema](ladybug-tools/honeybee-schema#12)
mostaphaRoudsari
approved these changes
Jan 14, 2020
chriswmackey
added a commit
to chriswmackey/honeybee-schema
that referenced
this pull request
Jan 14, 2020
This commit overhauls how HVAC systems are represented in the schema. Specifically, it makes it possible in the future to support HVAC systems that are assigned to multiple Rooms (like most of the HVAC system templates in honeybee_legacy). It also restructures the representation of HVAC within the Model schema in order to support this. This commit is coordinated with [this PR over on honeybee_energy](ladybug-tools/honeybee-energy#69)
chriswmackey
added a commit
to chriswmackey/honeybee-openstudio-gem
that referenced
this pull request
Jan 14, 2020
This commit overhauls how HVAC systems are represented in the schema. Specifically, it makes it possible in the future to support HVAC systems that are assigned to multiple Rooms (like most of the HVAC system templates in honeybee_legacy). It also restructures the representation of HVAC within the Model schema in order to support this. This commit is coordinated with [this PR over on honeybee_energy](ladybug-tools/honeybee-energy#69) and [this PR in honeybee_shcema](ladybug-tools/honeybee-schema#12)
This commit overhauls how HVAC systems are currently assigned to the Python objects and how they are represented in the schema. Specifically, it makes it possible in the future to support HVAC systems that are assigned to multiple Rooms (like most of the HVAC system templates in honeybee_legacy). It also restructures the representation of HVAC within the Model dictionary schema in order to support this. This commit also creates a base _HVACSystem class from which all HVAC systems will inherit and lays out simple ground rules for adding new HVAC classes to honeybee_energy. These ground rules will be followed when we eventually add the honeybee_energy_hvac extension. Lastly, I added a few new features to the IdealAirSystem class. Notably, I added heating/cooling availability schedules both as a means to test out how we will collect schedules across future detailed HVAC systems and because @zha specifically requested them :)
|
@mostaphaRoudsari , |
chriswmackey
added a commit
to ladybug-tools/honeybee-schema
that referenced
this pull request
Jan 14, 2020
This commit overhauls how HVAC systems are represented in the schema. Specifically, it makes it possible in the future to support HVAC systems that are assigned to multiple Rooms (like most of the HVAC system templates in honeybee_legacy). It also restructures the representation of HVAC within the Model schema in order to support this. This commit is coordinated with [this PR over on honeybee_energy](ladybug-tools/honeybee-energy#69)
|
🎉 This PR is included in version 1.23.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
chriswmackey
added a commit
to ladybug-tools/honeybee-grasshopper-core
that referenced
this pull request
Jan 14, 2020
This commit brings the plugin up-to-date with [this recent one on honeybee_energy](ladybug-tools/honeybee-energy#69).
chriswmackey
added a commit
to ladybug-tools/honeybee-grasshopper-energy
that referenced
this pull request
Jan 14, 2020
This commit brings the plugin up-to-date with [this recent one on honeybee_energy](ladybug-tools/honeybee-energy#69).
chriswmackey
added a commit
to ladybug-tools/honeybee-openstudio-gem
that referenced
this pull request
Jan 14, 2020
This commit overhauls how HVAC systems are represented in the schema. Specifically, it makes it possible in the future to support HVAC systems that are assigned to multiple Rooms (like most of the HVAC system templates in honeybee_legacy). It also restructures the representation of HVAC within the Model schema in order to support this. This commit is coordinated with [this PR over on honeybee_energy](ladybug-tools/honeybee-energy#69) and [this PR in honeybee_shcema](ladybug-tools/honeybee-schema#12)
chriswmackey
added a commit
to chriswmackey/honeybee-energy-standards
that referenced
this pull request
Jan 14, 2020
This commit brings the tests in line with [this PR](ladybug-tools/honeybee-energy#69) on honeybee_energy.
chriswmackey
added a commit
to chriswmackey/dragonfly-energy
that referenced
this pull request
Jan 14, 2020
This commit brings the tests in line with [this PR](ladybug-tools/honeybee-energy#69) on honeybee_energy.
chriswmackey
added a commit
to ladybug-tools/honeybee-energy-standards
that referenced
this pull request
Jan 14, 2020
This commit brings the tests in line with [this PR](ladybug-tools/honeybee-energy#69) on honeybee_energy.
chriswmackey
added a commit
to chriswmackey/dragonfly-energy
that referenced
this pull request
Jan 14, 2020
This commit brings the tests in line with [this PR](ladybug-tools/honeybee-energy#69) on honeybee_energy.
chriswmackey
added a commit
to ladybug-tools/dragonfly-energy
that referenced
this pull request
Jan 14, 2020
This commit brings the tests in line with [this PR](ladybug-tools/honeybee-energy#69) on honeybee_energy.
chriswmackey
added a commit
to chriswmackey/dragonfly-grasshopper
that referenced
this pull request
Jan 14, 2020
This commit brings the tests in line with [this PR](ladybug-tools/honeybee-energy#69) on honeybee_energy.
chriswmackey
added a commit
to ladybug-tools/dragonfly-grasshopper
that referenced
this pull request
Jan 14, 2020
This commit brings the tests in line with [this PR](ladybug-tools/honeybee-energy#69) on honeybee_energy.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit overhauls how HVAC systems are currently assigned to the Python objects and how they are represented in the schema.
Specifically, it makes it possible in the future to support HVAC systems that are assigned to multiple Rooms (like most of the HVAC system templates in honeybee_legacy). It also restructures the representation of HVAC within the Model dictionary schema in order to support this.
This commit also creates a base _HVACSystem class from which all HVAC systems will inherit and lays out simple ground rules for adding new HVAC classes to honeybee_energy. These ground rules will be followed when we eventually add the honeybee_energy_hvac extension.
Lastly, I added a few new features to the IdealAirSystem class. Notably, I added heating/cooling availability schedules both as a means to test out how we will collect schedules across future detailed HVAC systems and because @zha specifically requested them :)