refactor(designday): Pull DesignDay creation out into its own class

The SimulationParameter class was getting pretty long and the DesignDay is a pretty self-contained unit so I pulled it out into its own class.

lib/from_honeybee/model.rb

@@ -156,7 +156,7 @@ def to_openstudio_model(openstudio_model = nil)
     # create openstudio objects in the openstudio model
     def create_openstudio_objects
       # create all of the non-geometric model elements
-      puts 'Start of Model translation from Honeybee to OpenStudio'
+      puts 'Starting Model translation from Honeybee to OpenStudio'
       puts 'Translating Materials'
       create_materials
       puts 'Translating Constructions'
@@ -182,8 +182,7 @@ def create_openstudio_objects
       # create the hvac systems
       puts 'Translating HVAC Systems'
       create_hvacs
-      puts 'Done with translation!'
-      puts 'Writing out OSM and IDF files'
+      puts 'Done with Model translation!'
     end
 
     def create_materials

lib/from_honeybee/simulation/designday.rb

@@ -0,0 +1,105 @@
+# *******************************************************************************
+# Ladybug Tools Energy Model Schema, Copyright (c) 2019, Alliance for Sustainable
+# Energy, LLC, Ladybug Tools LLC and other contributors. All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are met:
+#
+# (1) Redistributions of source code must retain the above copyright notice,
+# this list of conditions and the following disclaimer.
+#
+# (2) Redistributions in binary form must reproduce the above copyright notice,
+# this list of conditions and the following disclaimer in the documentation
+# and/or other materials provided with the distribution.
+#
+# (3) Neither the name of the copyright holder nor the names of any contributors
+# may be used to endorse or promote products derived from this software without
+# specific prior written permission from the respective party.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDER(S) AND ANY CONTRIBUTORS
+# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+# THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+# ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER(S), ANY CONTRIBUTORS, THE
+# UNITED STATES GOVERNMENT, OR THE UNITED STATES DEPARTMENT OF ENERGY, NOR ANY OF
+# THEIR EMPLOYEES, BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+# EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT
+# OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
+# STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
+# OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+# *******************************************************************************
+
+require 'from_honeybee/model_object'
+
+require 'openstudio'
+
+module FromHoneybee
+  class DesignDay < ModelObject
+    attr_reader :errors, :warnings
+
+    def initialize(hash = {})
+      super(hash)
+    end
+
+    def defaults
+      @@schema[:components][:schemas][:DesignDay][:properties]
+    end
+
+    def find_existing_openstudio_object(openstudio_model)
+      object = openstudio_model.getDesignDayByName(@hash[:name])
+      return object.get if object.is_initialized
+      nil
+    end
+
+    def to_openstudio(openstudio_model)
+      # create the DesignDay object
+      os_des_day = OpenStudio::Model::DesignDay.new(openstudio_model)
+      os_des_day.setName(@hash[:name])
+      os_des_day.setDayType(@hash[:day_type])
+
+      # set the DryBulbCondition properties
+      os_des_day.setMaximumDryBulbTemperature(@hash[:dry_bulb_condition][:dry_bulb_max])
+      os_des_day.setDailyDryBulbTemperatureRange(@hash[:dry_bulb_condition][:dry_bulb_range])
+
+      # set the HumidityCondition properties
+      os_des_day.setHumidityIndicatingType(@hash[:humidity_condition][:humidity_type])
+      os_des_day.setHumidityIndicatingConditionsAtMaximumDryBulb(@hash[:humidity_condition][:humidity_value])
+      if @hash[:humidity_condition][:barometric_pressure]
+        os_des_day.setBarometricPressure(@hash[:humidity_condition][:barometric_pressure])
+      end
+      if @hash[:humidity_condition][:rain]
+        os_des_day.setRainIndicator(@hash[:humidity_condition][:rain])
+      end
+      if @hash[:humidity_condition][:snow_on_ground]
+        os_des_day.setSnowIndicator(@hash[:humidity_condition][:snow_on_ground])
+      end
+
+      # set the WindCondition properties
+      os_des_day.setWindSpeed(@hash[:wind_condition][:wind_speed])
+      if @hash[:wind_condition][:wind_direction]
+        os_des_day.setWindDirection(@hash[:wind_condition][:wind_direction])
+      end
+
+      # set the SkyCondition properties
+      os_des_day.setMonth(@hash[:sky_condition][:date][0])
+      os_des_day.setDayOfMonth(@hash[:sky_condition][:date][1])
+      os_des_day.setSolarModelIndicator(@hash[:sky_condition][:type])
+      if @hash[:sky_condition][:daylight_savings]
+        os_des_day.setDaylightSavingTimeIndicator(@hash[:sky_condition][:daylight_savings])
+      end
+
+      # ASHRAEClearSky SkyCondition
+      if @hash[:sky_condition][:type] == "ASHRAEClearSky"
+        os_des_day.setSkyClearness(@hash[:sky_condition][:clearness])
+      end
+
+      # ASHRAETau SkyCondition
+      if @hash[:sky_condition][:type] == "ASHRAETau"
+        os_des_day.setAshraeTaub(@hash[:sky_condition][:tau_b])
+        os_des_day.setAshraeTaud(@hash[:sky_condition][:tau_d])
+      end
+
+      os_des_day
+    end
+  end # DesignDay
+end # FromHoneybee

lib/from_honeybee/simulation/parameter.rb

@@ -31,6 +31,7 @@
 
 require 'from_honeybee/model_object'
 require 'from_honeybee/simulation/extension'
+require 'from_honeybee/simulation/designday'
 
 require 'openstudio'
 
@@ -89,13 +90,15 @@ def to_openstudio_model(openstudio_model = nil)
       @errors = []
       @warnings = []
 
+      puts 'Starting SimulationParameter translation from Honeybee to OpenStudio'
       @openstudio_model = if openstudio_model
                             openstudio_model
                           else
                             OpenStudio::Model::Model.new
                           end
 
       create_openstudio_objects
+      puts 'Done with SimulationParameter translation!'
 
       @openstudio_model
     end
@@ -174,39 +177,8 @@ def create_openstudio_objects
         # set any design days
         if @hash[:sizing_parameter][:design_days]
           @hash[:sizing_parameter][:design_days].each do |des_day|
-            os_des_day = OpenStudio::Model::DesignDay.new(@openstudio_model)
-            os_des_day.setName(des_day[:name])
-            os_des_day.setDayType(des_day[:day_type])
-            os_des_day.setMaximumDryBulbTemperature(des_day[:dry_bulb_condition][:dry_bulb_max])
-            os_des_day.setDailyDryBulbTemperatureRange(des_day[:dry_bulb_condition][:dry_bulb_range])
-            os_des_day.setHumidityIndicatingType(des_day[:humidity_condition][:humidity_type])
-            os_des_day.setHumidityIndicatingConditionsAtMaximumDryBulb(des_day[:humidity_condition][:humidity_value])
-            if des_day[:humidity_condition][:barometric_pressure]
-              os_des_day.setBarometricPressure(des_day[:humidity_condition][:barometric_pressure])
-            end
-            if des_day[:humidity_condition][:rain]
-              os_des_day.setRainIndicator(des_day[:humidity_condition][:rain])
-            end
-            if des_day[:humidity_condition][:snow_on_ground]
-              os_des_day.setSnowIndicator(des_day[:humidity_condition][:snow_on_ground])
-            end
-            os_des_day.setWindSpeed(des_day[:wind_condition][:wind_speed])
-            if des_day[:wind_condition][:wind_direction]
-              os_des_day.setWindDirection(des_day[:wind_condition][:wind_direction])
-            end
-            os_des_day.setMonth(des_day[:sky_condition][:date][0])
-            os_des_day.setDayOfMonth(des_day[:sky_condition][:date][1])
-            os_des_day.setSolarModelIndicator(des_day[:sky_condition][:type])
-            if des_day[:sky_condition][:daylight_savings]
-              os_des_day.setDaylightSavingTimeIndicator(des_day[:sky_condition][:daylight_savings])
-            end
-            if des_day[:sky_condition][:type] == "ASHRAEClearSky"
-              os_des_day.setSkyClearness(des_day[:sky_condition][:clearness])
-            end
-            if des_day[:sky_condition][:type] == "ASHRAETau"
-              os_des_day.setAshraeTaub(des_day[:sky_condition][:tau_b])
-              os_des_day.setAshraeTaud(des_day[:sky_condition][:tau_d])
-            end
+            des_day_object = DesignDay.new(des_day)
+            os_des_day = des_day_object.to_openstudio(@openstudio_model)
           end
         end
       end