-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Copy exported schedules to generated files dir, #204
Conversation
…oded to look in generated files dir first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @macumber ,
I tested this on my end and unfortunately it does not work as I would like. If the CSV file already exists before I run the measure, then I correctly get the CSV copied to the generated_files
directory. However, the measure currently writes out the CSV as it runs and, in this case, the CSV does not get copied at the end of the run by the new code that you have added here.
At this point, I am guessing that the intended behavior of the Schedule:File object in the OpenStudio SDK is to always write the CSVs into the generated_files directory as the measure runs. Do you want to give a try having the measure write to the generated_files directory as it encounters the Honeybee ScheduleFixedInterval
instead of writing it to the schedule_csv_dir
and trying to copy it at the end? That's the only way that I can imagine this might work. Otherwise, I would have to write out all of the CSV files from the honeybee/Python side before I call the OpenStudio CLI.
…ing windows slashes the file would get copied to generated files if it existed prior to running the measure but not if it was written during the measure
@chriswmackey can you try again? Something odd was going on with the slashes in the csv paths, when using windows slashes the file would get copied to generated files if it existed prior to running the measure but not if it was written during the measure. I noticed that measure.xml files are out of date. I didn't fix them here but you can do that with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works! Thanks @macumber . Merged!
🎉 This PR is included in version 2.17.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
OS Workflow is hard coded to look in generated files dir first