feat(radiance): Adding initial radiance schema materials.

[saeranv]

@chriswmackey

This is a draft of some radiance materials to review if this is the correct approach.

Schemas done:

• Primitive
• Plastic
• Glass
• Metal

[saeranv]

Note, this latest PR is for WIP discussion only, shouldn't be merged in yet.

[mostaphaRoudsari]

Note, this latest PR is for WIP discussion only, shouldn't be merged in yet.

Create a draft PR or you can now change it to draft:

[mostaphaRoudsari]

Hi @saeranv. See my comments. The recursive referencing should be fine. I shared the link on how you can set it up in Pydantic. Test it and let me know if it works for you.

[chriswmackey]

Thanks for getting this together @saeranv . It's looking good and most comments are minor.

[saeranv]

@mostaphaRoudsari @chriswmackey

Ready for review round 2.

[mostaphaRoudsari]

Hi @saeranv, Thank you for updating the PR quickly. Looks good overall but we won't know if the reference idea works until you add tests. Cheers.

[saeranv]

Hi @saeranv, Thank you for updating the PR quickly. Looks good overall but we won't know if the reference idea works until you add tests. Cheers.

@mostaphaRoudsari, I checked that it works by calling all the json schema in the if __name__ == '__main__': section. It was giving me an 'undefined class' error before, but with the references everything is working.

Do you still want me to add unit tests? In my last discussion with @chriswmackey we decided not to do any tests for now, but can take a look at it if needed.

[saeranv]

@mostaphaRoudsari, @chriswmackey

Revised, let me know if it's ready to be squashed and merged.

[mostaphaRoudsari]

Hi @saeranv, Other than tests it looks good to me. Can I ask why did you and @chriswmackey decide not to write tests at this point?

[saeranv]

Hi @saeranv, Other than tests it looks good to me. Can I ask why did you and @chriswmackey decide not to write tests at this point?

@mostaphaRoudsari nothing specific as I recall. I think it was just because I was just getting introduced to pydantic at that point and we figured we would revisit the question of testing at a later point.

[mostaphaRoudsari]

I see. Then let's add tests. It will save us in the near future. 😀

[chriswmackey]

I think this is good to squash and merge now.

@mostaphaRoudsari ,
Here is the plan for adding the tests: https://3.basecamp.com/4298486/buckets/13923324/question_answers/2577596456#__recording_2577711674
The reason why we are doing it this way is because I know it will be a lot faster for me to write a bunch of different sample JSONs than it will be for Saeran. Saeran will still write the code that runs the samples through his code and fix any bugs that he finds.

[ladybugbot]

🎉 This PR is included in version 1.22.0 🎉

The release is available on:

• GitHub release
• v1.22.0

Your semantic-release bot 📦🚀