Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: import weather data, sky rose, sky dome #397

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

TfedUD
Copy link
Contributor

@TfedUD TfedUD commented Nov 30, 2024

@chriswmackey I know there are a couple more, and you've just taken one off the list (multiple monthly wind roses). but I figured I'd PR what I had now and then keep working. Happy thanksgiving!

@chriswmackey
Copy link
Member

Thank, @TfedUD .

This is a big help. I'll take a look soon and merge it. I did the wind rose grid was just because someone asked for it yesterday. Good to know that you're working on the sample files in case another request came mes up.

Happy Thanksgiving to you too!

@TfedUD TfedUD marked this pull request as draft December 1, 2024 18:30
@TfedUD
Copy link
Contributor Author

TfedUD commented Dec 1, 2024

converted to draft as components need docstring update and I don't want to forget

@TfedUD TfedUD marked this pull request as ready for review December 6, 2024 18:05
@TfedUD
Copy link
Contributor Author

TfedUD commented Dec 6, 2024

There are still a few ladybug examples on hydrashare to get to but I wanted to get the 8 samples so far, reviewed incase there is a trending thing that is incorrect so I can fix it and do the other ones correctly.
Happy Friday!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants