Fix cookie parsing from headers in server request factory using globals. #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP used to encode space as '+' in the cookie header values in violation of the RFC. This was fixed in PHP 7.4. See https://bugs.php.net/bug.php?id=79174 Our cookie header parsing continued to decode '+' into space. This fix brings our implementation back into alignment with the supported PHP versions. Signed-off-by: Aleksei Khudiakov <aleksey@xerkus.pro>
Signed-off-by: Aleksei Khudiakov <aleksey@xerkus.pro>
gsteel
approved these changes
Sep 10, 2024
|
@gsteel You want to release it as 3.3.1? |
|
I think a 3.4.0 release is fine - I was questioning the change needing to go into 4.0 as a possible BC break, or not as the case may be |
|
There is no chance for BC break here. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP used to encode space in cookie values as + in violation of RFCs until it was fixed in PHP 7.4.
See https://bugs.php.net/bug.php?id=79174
We decode headers to read server request cookies when creating server request from globals. It was still converting
+in the cookie value back to space.This PR fixes our implementation to align it again with the supported PHP versions and RFCs.