Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update PHPDoc: allow StreamInterface in $streamOrFile in UploadedFile #69

Merged
merged 1 commit into from
Sep 15, 2021

Conversation

takoba
Copy link
Contributor

@takoba takoba commented Aug 17, 2021

Q A
Documentation yes
Bugfix no
BC Break no
New Feature no
RFC no
QA no

Description

When creating an UploadedFile that passed Stream, I was in trouble on PHPStan because $streamOrFile is not have annotation of StreamInterface. I improved it.

Signed-off-by: takoba <plane25@gmail.com>
@Ocramius Ocramius self-assigned this Sep 15, 2021
@Ocramius Ocramius added this to the 2.7.0 milestone Sep 15, 2021
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @takoba!

@Ocramius Ocramius merged commit 8b5792b into laminas:2.7.x Sep 15, 2021
@Ocramius Ocramius changed the title Update PHPDoc: allow StreamInterface in $streamOrFile in UploadedFile Update PHPDoc: allow StreamInterface in $streamOrFile in UploadedFile Sep 15, 2021
@takoba takoba deleted the modify-uploadedfile-phpdoc branch September 27, 2021 09:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants