Fix unserialization of header continuation / line folding #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per RFC 7230: > A user agent that receives an obs-fold in a response message that is > not within a message/http container MUST replace each received > obs-fold with one or more SP octets prior to interpreting the field > value. Thus a space must be inserted when concatenating the continuation line in AbstractSerializer::splitStream(). Signed-off-by: Tim Düsterhus <duesterhus@woltlab.com>
Ocramius
approved these changes
Apr 6, 2022
There was a problem hiding this comment.
LGTM - see https://datatracker.ietf.org/doc/html/rfc7230#section-3.2.4
@weierophinney do we want this in a minor, or a patch? It's probably just a bug, so 2.9.x?
|
Targeting |
|
Yes - in a minor. Thanks, @Ocramius ! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per RFC 7230:
Thus a space must be inserted when concatenating the continuation line in
AbstractSerializer::splitStream().