fix!: return a JSON string instead of dict to be consistent with type annotation #2772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chebbyChefNEQ
force-pushed
the
rmeng/fix-json
branch
from
0231a5b
to
c8135d6
Compare
eddyxu
approved these changes
Aug 22, 2024
Eh I think in Python actual behavior trumps type annotations. This will likely break user code. I'm still in favor of it. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is technically not a breaking change since we are making the return consistent with the existing type annotation.
marked as a breaking change so users are aware of this behavior change