Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add initial scanner statistics #3075

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

westonpace
Copy link
Contributor

This just captures some very basic statistics. I'd like to eventually add bytes read, decode time, and time waiting on I/O to the mix. However, those will need to wait for #2977 because those stats will go in the scheduler and we want one scan scheduler to be used in the entire plan first.

@github-actions github-actions bot added enhancement New feature or request python labels Oct 31, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 56.73077% with 45 lines in your changes missing coverage. Please review.

Project coverage is 77.60%. Comparing base (9e18322) to head (3a25450).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
rust/lance/src/dataset/scanner/stats.rs 45.94% 40 Missing ⚠️
rust/lance/src/dataset/scanner.rs 80.00% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3075      +/-   ##
==========================================
+ Coverage   77.57%   77.60%   +0.03%     
==========================================
  Files         240      241       +1     
  Lines       78683    79129     +446     
  Branches    78683    79129     +446     
==========================================
+ Hits        61040    61411     +371     
- Misses      14498    14573      +75     
  Partials     3145     3145              
Flag Coverage Δ
unittests 77.60% <56.73%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants