Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

perf: optimize reading transactions in commit loop #3117

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wjones127
Copy link
Contributor

  • Cache transaction files
  • Read transaction files with concurrency within commit loop

Closes #3057

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 70.70707% with 29 lines in your changes missing coverage. Please review.

Project coverage is 77.10%. Comparing base (4ab270b) to head (9b88d10).

Files with missing lines Patch % Lines
rust/lance/src/io/commit.rs 80.45% 5 Missing and 12 partials ⚠️
rust/lance-table/src/format/fragment.rs 0.00% 2 Missing and 4 partials ⚠️
rust/lance/src/dataset/transaction.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3117      +/-   ##
==========================================
- Coverage   77.12%   77.10%   -0.02%     
==========================================
  Files         240      240              
  Lines       80652    80698      +46     
  Branches    80652    80698      +46     
==========================================
+ Hits        62203    62225      +22     
- Misses      15279    15297      +18     
- Partials     3170     3176       +6     
Flag Coverage Δ
unittests 77.10% <70.70%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize IO scheduling for conflict resolution
2 participants