Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

core[minor]: used defusedxml for xml parsing #17250

Closed
wants to merge 8 commits into from
Closed

core[minor]: used defusedxml for xml parsing #17250

wants to merge 8 commits into from

Conversation

0xanis
Copy link

@0xanis 0xanis commented Feb 8, 2024

  • Dependencies: defusedxml

@vercel Vercel
Copy link

vercel bot commented Feb 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain 🛑 Canceled (Inspect) Feb 8, 2024 10:12pm

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. Ɑ: parsing Related to output parser module 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Feb 8, 2024
@eyurtsev eyurtsev self-requested a review February 8, 2024 17:48
@eyurtsev eyurtsev self-assigned this Feb 8, 2024
@eyurtsev
Copy link
Collaborator

eyurtsev commented Feb 8, 2024

Can merge if unit tests pass

@eyurtsev
Copy link
Collaborator

eyurtsev commented Feb 8, 2024

Thanks @0xanis

@eyurtsev eyurtsev changed the title Langchain-Core: patch xml output parser core[patch]: patch xml output parser Feb 8, 2024
@0xanis
Update xml.py
d28ec63 
to fix `I001 Import block is un-sorted or un-formatted` failed test
@0xanis
Copy link
Author

0xanis commented Feb 8, 2024 •
edited
Loading

hi @eyurtsev test units failed because of two errors:

  • I001 Import block is un-sorted or un-formatted : i have made another commit that will probably fix this error
  • ModuleNotFoundError: No module named 'defusedxml' : you have to add defusedxml to poetry and am not sure how to do that , can you help me ?

@baskaryan baskaryan changed the title core[patch]: patch xml output parser core[minor]: patch xml output parser Feb 8, 2024
@baskaryan baskaryan changed the title core[minor]: patch xml output parser core[minor]: used defusedxml for xml parsing Feb 8, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Feb 8, 2024
@eyurtsev eyurtsev mentioned this pull request Mar 25, 2024
Merged
@eyurtsev eyurtsev closed this Mar 27, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@eyurtsev eyurtsev Awaiting requested review from eyurtsev

Assignees

@eyurtsev eyurtsev

Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature Ɑ: parsing Related to output parser module size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xanis @eyurtsev @baskaryan