-
Notifications
You must be signed in to change notification settings - Fork 15.9k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
partners: add similarity search by image functionality to langchain_chroma partner package #22982
Conversation
mrugank-wadekar
commented
Jun 17, 2024
- Description: This pull request introduces two new methods to the Langchain Chroma partner package that enable similarity search based on image embeddings. These methods enhance the package's functionality by allowing users to search for images similar to a given image URI. Also introduces a notebook to demonstrate it's use.
- Issue: N/A
- Dependencies: None
- Twitter handle: @mrugank9009
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
way too many files have been changes, probably need to rebase or something
Hi this is my first time contributing, |
- by image - by image with relevance score
…g CLIP and new features added to Chroma partner package from last commit .
I've modified my branch to affect only the .py files, do let me know if there's anything more I need to do. |
@tazarov would you mind taking a look at this one? Thanks! |
Hi @tazarov , can i expect a merge with this one? |
Would updating the branch help for CI Success? If not, would appreciate some guidance on this. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! For future reference, CI was held up by code formatting. Please see contribution guidelines here for how to resolve.
Left a minor comment and would welcome any follow-up PRs. If you can put together a concise ~10 line snippet for demonstration, would be worth adding it:
if self._embedding_function is None or not hasattr( | ||
self._embedding_function, "embed_image" | ||
): | ||
raise ValueError("The embedding function must support image embedding.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider explicitly spelling out the required name here ("embed_image")
Hi thanks, for merging! |