Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix docstring for ollama parameter "keep_alive" #23973

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

rick-github
Copy link
Contributor

Thank you for contributing to LangChain!

  • PR title: "community: fix docstring for ollama parameter 'keep_alive'"

  • PR message: Delete this entire checklist and replace with

  • Add tests and docs: If you're adding a new integration, please include

    1. a test for the integration, preferably unit tests that do not rely on network access,
    2. an example notebook showing its use. It lives in docs/docs/integrations directory.
  • Lint and test: Run make format, make lint and make test from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/

Additional guidelines:

  • Make sure optional dependencies are imported within a function.
  • Please do not add dependencies to pyproject.toml files (even optional ones) unless they are required for unit tests.
  • Most PRs should not touch more than one package.
  • Changes should be backwards compatible.
  • If you are adding something to community, do not re-import it in langchain.

If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.

Copy link

vercel bot commented Jul 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2024 11:43pm

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. community Related to langchain-community 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels Jul 8, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Jul 8, 2024
@eyurtsev eyurtsev self-assigned this Jul 8, 2024
@eyurtsev eyurtsev enabled auto-merge (squash) July 8, 2024 15:56
auto-merge was automatically disabled July 15, 2024 23:39

Head branch was pushed to by a user without write access

@eyurtsev eyurtsev enabled auto-merge (squash) July 16, 2024 14:44
@eyurtsev eyurtsev merged commit c59e663 into langchain-ai:master Jul 16, 2024
43 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
community Related to langchain-community 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder lgtm PR looks good. Use to confirm that a PR is ready for merging. size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants