Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

import tqdm.auto instead of tqdm tqdm for OpenAIEmbeddings #9584

Merged
merged 2 commits into from
Aug 22, 2023
Merged

import tqdm.auto instead of tqdm tqdm for OpenAIEmbeddings #9584

merged 2 commits into from
Aug 22, 2023

Conversation

amicus-veritatis
Copy link
Contributor

@vercel
Copy link

vercel bot commented Aug 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2023 4:52pm

@dosubot dosubot bot added Ɑ: embeddings Related to text embedding models module 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs labels Aug 22, 2023
@amicus-veritatis amicus-veritatis changed the title import tqdm.auto instead of tqdm, for jupyter notebook compatibility import tqdm.auto instead of tqdm tqdm for OpenAIEmbeddings Aug 22, 2023
@eyurtsev eyurtsev added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Aug 22, 2023
@eyurtsev
Copy link
Collaborator

Thanks @amicus-veritatis, will merge after tests pass

@eyurtsev eyurtsev merged commit f1e6029 into langchain-ai:master Aug 22, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@eyurtsev eyurtsev eyurtsev approved these changes

Assignees
No one assigned
Labels
Ɑ: embeddings Related to text embedding models module lgtm PR looks good. Use to confirm that a PR is ready for merging. 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amicus-veritatis @eyurtsev