Skip to content

Commit

Permalink
fix: tools as requried=False in Agents (#4525)
Browse files Browse the repository at this point in the history
Update agent.py

tools as not required by default.
  • Loading branch information
edwinjosechittilappilly authored Nov 12, 2024
1 parent 145d67f commit aca2b4b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 8 deletions.
2 changes: 1 addition & 1 deletion src/backend/base/langflow/base/agents/agent.py
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ class LCToolsAgentComponent(LCAgentComponent):
display_name="Tools",
input_types=["Tool", "BaseTool", "StructuredTool"],
is_list=True,
required=True,
required=False,
info="These are the tools that the agent can use to help with tasks.",
),
*LCAgentComponent._base_inputs,
Expand Down
11 changes: 4 additions & 7 deletions src/backend/tests/unit/custom/custom_component/test_component.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import pytest
from langflow.components.agents import AgentComponent
from langflow.components.crewai import CrewAIAgentComponent, SequentialTaskComponent
from langflow.components.inputs import ChatInput
from langflow.components.langchain_utilities import ToolCallingAgentComponent
from langflow.components.models import OpenAIModelComponent
from langflow.components.outputs import ChatOutput
from langflow.template import Output
Expand Down Expand Up @@ -43,21 +43,18 @@ def test_set_required_inputs_various_components():
chatinput = ChatInput()
chatoutput = ChatOutput()
task = SequentialTaskComponent()
tool_calling_agent = ToolCallingAgentComponent()
agent = AgentComponent()
openai_component = OpenAIModelComponent()

assert all(_output_required_inputs_are_in_inputs(output, chatinput._inputs) for output in chatinput.outputs)
assert all(_output_required_inputs_are_in_inputs(output, chatoutput._inputs) for output in chatoutput.outputs)
assert all(_output_required_inputs_are_in_inputs(output, task._inputs) for output in task.outputs)
assert all(
_output_required_inputs_are_in_inputs(output, tool_calling_agent._inputs)
for output in tool_calling_agent.outputs
)
assert all(_output_required_inputs_are_in_inputs(output, agent._inputs) for output in agent.outputs)
assert all(
_output_required_inputs_are_in_inputs(output, openai_component._inputs) for output in openai_component.outputs
)

assert _assert_all_outputs_have_different_required_inputs(chatinput.outputs)
assert _assert_all_outputs_have_different_required_inputs(chatoutput.outputs)
assert _assert_all_outputs_have_different_required_inputs(task.outputs)
assert _assert_all_outputs_have_different_required_inputs(tool_calling_agent.outputs)
assert _assert_all_outputs_have_different_required_inputs(agent.outputs)

0 comments on commit aca2b4b

Please # to comment.