Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: custom post loading and add AppAuthenticatedPage #3632

Merged
merged 6 commits into from
Aug 30, 2024

Conversation

lucaseduoli
Copy link
Collaborator

This pull request refactors the custom post loading functionality by adding a new hook called useCustomPostAuth. The useCustomPostAuth hook is used in the AppAuthenticatedPage component, which is now used inside the protected route. These changes improve the code structure and organization.

@lucaseduoli lucaseduoli self-assigned this Aug 30, 2024
@lucaseduoli lucaseduoli enabled auto-merge (squash) August 30, 2024 16:14
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request javascript Pull requests that update Javascript code labels Aug 30, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3632.dmtpw4p5recq1.amplifyapp.com

Copy link
Collaborator

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 30, 2024
@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed enhancement New feature or request labels Aug 30, 2024
@lucaseduoli lucaseduoli merged commit 3bef9aa into main Aug 30, 2024
20 checks passed
@lucaseduoli lucaseduoli deleted the refactor/post_loading branch August 30, 2024 17:53
carlosrcoelho pushed a commit that referenced this pull request Sep 2, 2024
* Added post loading hook to appInitPage

* Removed custom post loading

* Changed custom post loading to cusotm post auth

* Adds AppAuthenticatedPage

* Uses AppAuthenticatedPage inside protected route
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer refactor Maintenance tasks and housekeeping size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants