feat: add stop button on Playground Chat #3704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… constants for better readability and maintainability 🐛 (buttonSendWrapper/index.tsx): fix logic to disable button when chat is locked and not building 🐛 (buttonSendWrapper/index.tsx): fix conditional rendering of icons based on button state
dosubot
bot
added
size:M
github-actions
bot
added
enhancement
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…building from inside Playground.
dosubot
bot
added
size:L
…tly prioritize showStopButton condition and improve code readability
…stopped" text is visible after clicking on the stop button
…tion to getButtonState for better clarity and consistency in naming 🐛 (buttonSendWrapper/index.tsx): fix logic in handleClick function to properly handle the conditions for sending messages and stopping building process
…w-ai/langflow into cz/ux-playground-stopbtn
Cristhianzl
requested review from
anovazzi1
and removed request for
anovazzi1
…w-ai/langflow into cz/ux-playground-stopbtn
…ser agent information for conditional logic based on operating system 📝 (stop-button-playground.spec.ts): update comments and documentation for better code readability and understanding
diogocabral
pushed a commit
to headlinevc/langflow
that referenced
this pull request
Nov 26, 2024
* 📝 (buttonSendWrapper/index.tsx): refactor button styling logic to use constants for better readability and maintainability 🐛 (buttonSendWrapper/index.tsx): fix logic to disable button when chat is locked and not building 🐛 (buttonSendWrapper/index.tsx): fix conditional rendering of icons based on button state * ✨ (stop-button-playground.spec.ts): Add end-to-end test for stopping building from inside Playground. * 🔧 (buttonSendWrapper/index.tsx): refactor conditional logic to correctly prioritize showStopButton condition and improve code readability * ✅ (stop-button-playground.spec.ts): add assertion to check if "build stopped" text is visible after clicking on the stop button
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the button styling logic in
buttonSendWrapper/index.tsxto use constants for better readability and maintainability.Additionally, fixed the logic to disable the button when the chat is locked and not building, and also fixed the conditional rendering of icons based on the button state.
This pull request improves the code structure and ensures correct button behavior in the chat input component.
🐛 (buttonSendWrapper/index.tsx): fix logic to disable button when chat is locked and not building
🐛 (buttonSendWrapper/index.tsx): fix conditional rendering of icons based on button state
📝 (buttonSendWrapper/index.tsx): refactor button styling logic to use constants for better readability and maintainability