Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: OpenAI client url correctly passed #4386

Merged
merged 3 commits into from
Nov 4, 2024
Merged

Conversation

erichare
Copy link
Collaborator

@erichare erichare commented Nov 4, 2024

This fixes #4385 with the upgrade to langchain~=0.3.x

@erichare erichare requested a review from Cristhianzl November 4, 2024 17:19
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working labels Nov 4, 2024
Copy link
Member

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 4, 2024
…s are not set and improve test readability and maintainability by refactoring test logic and adding comments.
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Nov 4, 2024
@ogabrielluiz ogabrielluiz changed the title FIX #4385: OpenAI client url correctly passed fix: OpenAI client url correctly passed Nov 4, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Nov 4, 2024
@Cristhianzl Cristhianzl merged commit 8fb0fae into main Nov 4, 2024
28 of 29 checks passed
@Cristhianzl Cristhianzl deleted the bugfix-openai-client-url branch November 4, 2024 21:00
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
* FIX langflow-ai#4385: OpenAI client url correctly passed

* ✨ (Vector Store.spec.ts): Skip tests if required environment variables are not set and improve test readability and maintainability by refactoring test logic and adding comments.

---------

Co-authored-by: cristhianzl <cristhian.lousa@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenAI Embeddings do not work due to a connection error
2 participants