Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Revert "fix: Optimize Setting of Output Required Inputs" #4404

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Revert "fix: Optimize Setting of Output Required Inputs" #4404

merged 1 commit into from
Nov 5, 2024

Conversation

ogabrielluiz
Copy link
Contributor

@ogabrielluiz ogabrielluiz commented Nov 5, 2024 •
edited
Loading

Reverts #4389 because it caused the starter projects update logic to change wrong parameters.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 5, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) November 5, 2024 13:16
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 5, 2024

CodSpeed Performance Report

Merging #4404 will degrade performances by 91.08%

Comparing revert-4389-fix-agent-as-tools (710da8d) with main (7cc497a)

Summary

⚡ 1 improvements
❌ 2 regressions
✅ 13 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main revert-4389-fix-agent-as-tools Change
❌ test_starter_projects 993.3 ms 1,130.5 ms -12.14%
❌ test_successful_run_with_input_type_chat 450.8 ms 5,056.6 ms -91.08%
⚡ test_successful_run_with_output_type_debug 527.4 ms 451.3 ms +16.86%

edwinjosechittilappilly
edwinjosechittilappilly approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@edwinjosechittilappilly edwinjosechittilappilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 5, 2024
@ogabrielluiz ogabrielluiz force-pushed the revert-4389-fix-agent-as-tools branch from 710da8d to 498a131 Compare November 5, 2024 15:46
@ogabrielluiz ogabrielluiz merged commit 7b5ba8e into main Nov 5, 2024
27 of 28 checks passed
@ogabrielluiz ogabrielluiz deleted the revert-4389-fix-agent-as-tools branch November 5, 2024 15:55
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
@ogabrielluiz @diogocabral
Revert "fix: Optimize Setting of Output Required Inputs" (langflow-ai…
a2de804 
…#4404)

Revert "fix: Optimize Setting of Output Required Inputs (langflow-ai#4389)"

This reverts commit 7cc497a.
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@edwinjosechittilappilly edwinjosechittilappilly edwinjosechittilappilly approved these changes

@italojohnny italojohnny Awaiting requested review from italojohnny

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ogabrielluiz @edwinjosechittilappilly