Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: rename CSV component and update Google OAuth imports #4521

Merged
merged 7 commits into from
Nov 12, 2024

Conversation

Cristhianzl
Copy link
Member

This pull request includes several changes across multiple files, primarily focusing on renaming a component, updating imports, and cleaning up unused imports in test files. Here are the most important changes:

Component Renaming:

Import Updates:

@Cristhianzl Cristhianzl self-assigned this Nov 12, 2024
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 12, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Nov 12, 2024
@github-actions github-actions bot added the refactor Maintenance tasks and housekeeping label Nov 12, 2024
Copy link

codspeed-hq bot commented Nov 12, 2024

CodSpeed Performance Report

Merging #4521 will degrade performances by 12.5%

Comparing cz/csv-data-google (2da13f5) with main (516ba89)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 12 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main cz/csv-data-google Change
test_successful_run_with_input_type_any 505 ms 455.2 ms +10.96%
test_successful_run_with_output_type_any 456.2 ms 390.4 ms +16.87%
test_successful_run_with_output_type_debug 455.9 ms 521.1 ms -12.5%

@Cristhianzl Cristhianzl enabled auto-merge (squash) November 12, 2024 14:19
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 12, 2024
@Cristhianzl Cristhianzl merged commit 2ddd773 into main Nov 12, 2024
29 checks passed
@Cristhianzl Cristhianzl deleted the cz/csv-data-google branch November 12, 2024 15:22
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
…low-ai#4521)

* change csv to data name, change googleauth folder

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
lgtm This PR has been approved by a maintainer refactor Maintenance tasks and housekeeping size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants