Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: issue with dynamic inputs when selecting model #4538

Merged
merged 5 commits into from
Nov 12, 2024
Merged

fix: issue with dynamic inputs when selecting model #4538

merged 5 commits into from
Nov 12, 2024

Conversation

erichare
Copy link
Collaborator

This pull request fixes an issue with the dynamic model selection in Astra DB Component

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 12, 2024
@erichare erichare requested a review from Cristhianzl November 12, 2024 18:22
@dosubot dosubot bot added the bug Something isn't working label Nov 12, 2024
@erichare erichare enabled auto-merge (squash) November 12, 2024 18:23
Cristhianzl
Cristhianzl approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 12, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Nov 12, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 12, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #4538 will degrade performances by 14.27%

Comparing bugfix-astra-db-inputs (23d2ec8) with main (0dc6cce)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 12 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main bugfix-astra-db-inputs Change
⚡ test_invalid_run_with_input_type_chat 16.6 ms 13.8 ms +20.56%
⚡ test_successful_run_with_input_type_any 543.2 ms 455 ms +19.4%
❌ test_successful_run_with_input_type_text 455.9 ms 531.8 ms -14.27%

@erichare erichare merged commit 1dfa160 into main Nov 12, 2024
29 checks passed
@erichare erichare deleted the bugfix-astra-db-inputs branch November 12, 2024 19:58
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
@erichare @diogocabral
fix: issue with dynamic inputs when selecting model (langflow-ai#4538)
5e9ca49
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Cristhianzl Cristhianzl Cristhianzl approved these changes

Assignees
No one assigned
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erichare @Cristhianzl