Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

adding ability for APIRequest to retry and save to a file #4677

Merged
merged 18 commits into from
Nov 26, 2024

Conversation

mieslep
Copy link
Contributor

@mieslep mieslep commented Nov 18, 2024

No description provided.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Nov 18, 2024
Copy link

codspeed-hq bot commented Nov 18, 2024

CodSpeed Performance Report

Merging #4677 will degrade performances by 28.54%

Comparing mieslep:phil/api-request (3553ac6) with main (3c83e15)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 13 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main mieslep:phil/api-request Change
test_successful_run_with_input_type_any 324.9 ms 231.7 ms +40.19%
test_successful_run_with_output_type_debug 229.7 ms 321.4 ms -28.54%

@erichare erichare self-requested a review November 18, 2024 16:45
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Nov 19, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Nov 19, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 19, 2024
@erichare erichare added the DO NOT MERGE Don't Merge this PR label Nov 19, 2024
@erichare
Copy link
Collaborator

Looks fantastic. Thanks @mieslep . Approving and temporarily marking as DO NOT MERGE as this will go into the release following this week's.

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Nov 22, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Nov 22, 2024
@erichare erichare removed the DO NOT MERGE Don't Merge this PR label Nov 26, 2024
@erichare erichare merged commit 654b443 into langflow-ai:main Nov 26, 2024
24 checks passed
@mieslep mieslep deleted the phil/api-request branch December 4, 2024 13:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants