Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix: simple agent template notes #4709

Merged
merged 24 commits into from
Nov 20, 2024

Conversation

mendonk
Copy link
Collaborator

@mendonk mendonk commented Nov 19, 2024

  • Remove youtube starter template
  • Replace existing simple agent.json with updated readme, description, and key node.
Screenshot 2024-11-19 at 11 28 30 AM

@mendonk mendonk self-assigned this Nov 19, 2024
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Nov 19, 2024
Copy link

codspeed-hq bot commented Nov 19, 2024

CodSpeed Performance Report

Merging #4709 will degrade performances by 42.62%

Comparing fix-simple-agent-template-notes (962869a) with main (a0acf39)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 12 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix-simple-agent-template-notes Change
test_successful_run_with_input_type_any 298.1 ms 187.4 ms +59.04%
test_successful_run_with_output_type_any 141.1 ms 245.9 ms -42.62%
test_successful_run_with_output_type_debug 249.7 ms 216.5 ms +15.33%

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 19, 2024
@ogabrielluiz
Copy link
Contributor

Hey @mendonk

The conflicts are just due to formatting. If you fix them, please run the backend once to make sure the formatting is correct.

@ogabrielluiz
Copy link
Contributor

Hey @mendonk there's probably something wrong with the JSON you added.

@edwinjosechittilappilly
Copy link
Collaborator

@mendonk Docs are spinning up.
Investigating why the playwright tests failed!

@mendonk
Copy link
Collaborator Author

mendonk commented Nov 20, 2024

@edwinjosechittilappilly the docs are OK
The JSON issue yesterday was because I didn't have a [tag] in the file
Try to start the simple-agent starter template flow in this branch, that's where the issue im seeing is

@edwinjosechittilappilly
Copy link
Collaborator

Error in Simple agent flow template:

Flow is Saved correctly, But when loaded as a template, the edges from the URL component as Tools to the agent are missing.
@ogabrielluiz.
We are not updating the flows anywhere in front end, right?

@edwinjosechittilappilly edwinjosechittilappilly merged commit 3e57340 into main Nov 20, 2024
30 checks passed
@edwinjosechittilappilly edwinjosechittilappilly deleted the fix-simple-agent-template-notes branch November 20, 2024 20:24
mieslep pushed a commit to mieslep/langflow that referenced this pull request Nov 22, 2024
* delete-youtube-template

* update-simple-agent

* update-description

* docs-package-and-yarn-lock

* update-edges

* descriptions-and-markdown

* readme

* tags

* update

hotfix for the tool_kit mode component update

* Update Simple Agent.json

added project tags

* Update Simple Agent.spec.ts

Playwright test update

* Update Simple Agent.spec.ts

* Update starter-projects.spec.ts

remove  youtube flow  from templates in test

---------

Co-authored-by: Gabriel Luiz Freitas Almeida <gabriel@langflow.org>
Co-authored-by: Edwin Jose <edwin.jose@datastax.com>
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
* delete-youtube-template

* update-simple-agent

* update-description

* docs-package-and-yarn-lock

* update-edges

* descriptions-and-markdown

* readme

* tags

* update

hotfix for the tool_kit mode component update

* Update Simple Agent.json

added project tags

* Update Simple Agent.spec.ts

Playwright test update

* Update Simple Agent.spec.ts

* Update starter-projects.spec.ts

remove  youtube flow  from templates in test

---------

Co-authored-by: Gabriel Luiz Freitas Almeida <gabriel@langflow.org>
Co-authored-by: Edwin Jose <edwin.jose@datastax.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants