Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: tool mode for all vector store components #5348

Merged
merged 6 commits into from
Dec 19, 2024

Conversation

erichare
Copy link
Collaborator

This pull request factors out the search query and ingest data inputs for vector stores in order to add tool mode to all available vector stores. It also includes some UI fixes for Astra DB.

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Dec 18, 2024
@dosubot dosubot bot added the enhancement New feature or request label Dec 18, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Dec 18, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Dec 18, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Dec 18, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Dec 18, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Dec 18, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Dec 18, 2024
Copy link

codspeed-hq bot commented Dec 18, 2024

CodSpeed Performance Report

Merging #5348 will degrade performances by 43.14%

Comparing feat-vectorstore-toolmode (90aec0f) with main (2db5f93)

Summary

❌ 2 regressions
✅ 13 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main feat-vectorstore-toolmode Change
test_setup_llm_caching 1.2 ms 2.1 ms -43.14%
test_successful_run_with_input_type_text 174.4 ms 258.3 ms -32.49%

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 19, 2024
@ogabrielluiz ogabrielluiz added the DO NOT MERGE Don't Merge this PR label Dec 19, 2024
@erichare erichare added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit 22877ae Dec 19, 2024
55 of 71 checks passed
@erichare erichare deleted the feat-vectorstore-toolmode branch December 19, 2024 17:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
DO NOT MERGE Don't Merge this PR enhancement New feature or request lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants