Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Disable tool model by default in various model components #5989

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

ogabrielluiz
Copy link
Contributor

@ogabrielluiz ogabrielluiz commented Jan 29, 2025

Set the tool_model_enabled parameter to False by default across multiple model components, promoting a more conservative initial configuration for tool-based models.

Setting it to True by default makes current the components have an unexpected behaviour.

Fixes #5944

Update multiple model components to set the `tool_model_enabled` parameter to `False` by default, ensuring a more conservative initial configuration for tool-based models across Anthropic, Google Generative AI, Groq, NVIDIA, and Ollama components.
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 29, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jan 29, 2025
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jan 29, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jan 29, 2025
@ogabrielluiz ogabrielluiz requested a review from erichare January 29, 2025 01:16
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 29, 2025
@ogabrielluiz ogabrielluiz added this pull request to the merge queue Jan 29, 2025
Merged via the queue into main with commit 9966f88 Jan 29, 2025
43 of 52 checks passed
@ogabrielluiz ogabrielluiz deleted the tool-mode-off-ollama branch January 29, 2025 01:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ollama Host Field Empty and Models Not Fully Displayed After Refresh on 1.1.2
2 participants