Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs: Update GCP deployment documentation to clarify # details #6005

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

mendonk
Copy link
Collaborator

@mendonk mendonk commented Jan 29, 2025

This pull request includes a change to the docs/docs/Deployment/deployment-gcp.md file, which simplifies the # section by removing the detailed cost table and associated notes.

Also, the deployment script still works.

@mendonk mendonk self-assigned this Jan 29, 2025
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. documentation Improvements or additions to documentation labels Jan 29, 2025
@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Jan 29, 2025
Copy link
Collaborator

@KimberlyFields KimberlyFields left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion on capitalization, but approving.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 29, 2025
mendonk and others added 2 commits January 29, 2025 14:27
Co-authored-by: KimberlyFields <46325568+KimberlyFields@users.noreply.github.com>
@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Jan 29, 2025
@mendonk mendonk enabled auto-merge January 29, 2025 19:28
@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Jan 29, 2025
@mendonk mendonk added this pull request to the merge queue Jan 29, 2025
Merged via the queue into main with commit 441bfed Jan 29, 2025
10 checks passed
@mendonk mendonk deleted the docs-update-gcp-# branch January 29, 2025 19:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants