Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: resolve component update notification state persistence after dismissal #6032

Merged
merged 7 commits into from
Feb 5, 2025

Conversation

Cristhianzl
Copy link
Member

This pull request introduces a new feature to handle the dismissal of update notifications for components. The changes span across multiple files to integrate this feature into the existing codebase.

New Feature: Dismiss All Updates

Utility Store Enhancements

Additional Integrations

… to manage dismissAll state

🔧 (GenericNode): Import and use utility store in GenericNode component to access dismissAll state
🔧 (use-reset-dismiss-update-all): Create hook to reset dismissAll state in utility store
🔧 (UpdateAllComponents): Import and use utility store in UpdateAllComponents component to access dismissAll state
🔧 (header): Import useResetDismissUpdateAll hook in header component to reset dismissAll state
🔧 (list): Import useResetDismissUpdateAll hook in list component to reset dismissAll state
🔧 (utilityStore): Add dismissAll state and setDismissAll method to utility store
🔧 (utility/index): Add dismissAll state and setDismissAll method to UtilityStoreType
… to handle dismissing all notifications

✨ (GenericNode/index.tsx): add dismissAll prop to GenericNode component to handle dismissing all notifications
✨ (UpdateAllComponents/index.tsx): add e.stopPropagation() to onClick event handler to prevent event bubbling
🔧 (header/index.tsx): remove unused import useResetDismissUpdateAll from header component
…onent when it is outdated and not user-edited

🔧 (GenericNode/index.tsx): Update handleUpdateComponent function to handleUpdateCode for consistency
🔧 (appHeaderComponent/index.tsx): Add useResetDismissUpdateAll hook to reset dismiss update all functionality
🔧 (use-reset-dismiss-update-all.ts): Update useResetDismissUpdateAll hook to only reset dismiss update all in flow location path
🔧 (list/index.tsx): Remove useResetDismissUpdateAll hook from ListComponent as it is no longer needed
🔧 (index.css): Remove extra whitespace in CSS file
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Jan 30, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 30, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 3, 2025
@Cristhianzl Cristhianzl self-assigned this Feb 4, 2025
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 4, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 4, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 5, 2025
@Cristhianzl Cristhianzl added this pull request to the merge queue Feb 5, 2025
Merged via the queue into main with commit 6b17240 Feb 5, 2025
22 checks passed
@Cristhianzl Cristhianzl deleted the cz/dismiss-all-updates branch February 5, 2025 13:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants