Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: update Cohere embedding model to use langchain_cohere, added support to dynamically load latest embedding models, improved error handling #6034

Merged
merged 6 commits into from
Feb 6, 2025

Conversation

edwinjosechittilappilly
Copy link
Collaborator

This pull request includes several changes to the CohereEmbeddingsComponent class in the src/backend/base/langflow/components/embeddings/cohere.py file, as well as a minor update to the pyproject.toml file. The changes focus on improving the functionality and robustness of the CohereEmbeddingsComponent class.

Improvements to CohereEmbeddingsComponent class:

  • Added import statements for Any from typing and cohere library.
  • Updated SecretStrInput and DropdownInput fields to include real-time refresh, refresh button, and combobox options. [1] [2]
  • Enhanced the build_embeddings method to include error handling and status updates.
  • Introduced the get_model method to fetch available models from the Cohere API.
  • Added update_build_config method to dynamically update the build configuration based on field values.

Minor update to pyproject.toml:

  • Fixed a trailing comma in the dependencies list.

closes: #5943

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 30, 2025
@dosubot dosubot bot added the enhancement New feature or request label Jan 30, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 30, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 31, 2025
@dosubot dosubot bot removed the lgtm This PR has been approved by a maintainer label Jan 31, 2025
Co-authored-by: Gabriel Luiz Freitas Almeida <gabriel@langflow.org>
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 31, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 31, 2025
@edwinjosechittilappilly
Copy link
Collaborator Author

@ogabrielluiz can we merge it!

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 31, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 3, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 6, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 6, 2025
@edwinjosechittilappilly edwinjosechittilappilly added this pull request to the merge queue Feb 6, 2025
Merged via the queue into main with commit e89edc3 Feb 6, 2025
41 of 42 checks passed
@edwinjosechittilappilly edwinjosechittilappilly deleted the fix-serialise-error-embeddings branch February 6, 2025 17:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embeddings model no longer working in 1.1.2
3 participants