refactor: prevent disconnected handles from executing when input template edge is hidden #6132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lter out edges based on hidden fields in node templates
dosubot
bot
added
the
size:S
Cristhianzl
added
DO NOT MERGE
github-actions
bot
added
refactor
…accept targetNode directly instead of nodes array to improve code readability and maintainability
dosubot
bot
added
the
size:S
github-actions
bot
added
refactor
anovazzi1
requested changes
Feb 6, 2025
github-actions
bot
added
refactor
…out null check, causing potential runtime error
…/langflow into cz/fix-handle-hidden
github-actions
bot
added
refactor
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
src/frontend/src/utils/reactflowUtils.tsfile to enhance the handling of edges in the React Flow utility functions. The most important changes include the addition of a new function to filter hidden field edges and the integration of this function into the existing edge cleaning process.Enhancements to edge handling:
src/frontend/src/utils/reactflowUtils.ts: Added a new functionfilterHiddenFieldsEdgesto filter out edges that should be hidden based on the node's template and input types.src/frontend/src/utils/reactflowUtils.ts: Modified thecleanEdgesfunction to call the newfilterHiddenFieldsEdgesfunction, ensuring that hidden field edges are properly filtered.